form icon indicating copy to clipboard operation
form copied to clipboard

Default Reducer not updating the store

Open krisvegh opened this issue 7 years ago • 4 comments

This is a...

  • [ ] feature request
  • [x] bug report
  • [ ] usage question

What toolchain are you using for transpilation/bundling?

  • [ ] @angular/cli
  • [x] Custom @ngTools/webpack
  • [ ] Raw ngc
  • [ ] SystemJS
  • [ ] Rollup
  • [ ] Other

Environment

NodeJS Version: 8.1.1 Typescript Version: 2.3.4 Angular Version: 4.1.2 @angular-redux/store version: 7.1.1 @angular/cli version: (if applicable) OS: OSX

Link to repo showing the issus

(optional, but helps a lot)

Expected Behaviour:

Input field on change should update the corresponding value in the redux store.

Actual Behaviour:

Input field value doesn't change on keystroke, as it's bound to the store which is not updating.

Stack Trace/Error Message:

Additional Notes:

Just need some help please. Any idea where the problem could be?

<form [connect]="['advertiser', 'campaign', 'campaign']">
    <div class="input-container">
        <input
            ngControl
            ngModel
            class="form-control"
            type="text"
            name="name">
    </div>
</form>

1: The input field shows the value coming from the redux store, so the path is good. 2: On keydown, I can see the action firing in the devtools, payload looks fine. 3. When I inspect State.assign in state.js, state, path, and value arguments look fine but for some reason, the state doesn't get updated. Sorry I can't show repo, but maybe someone has any idea what I'm missing.

Thank you.

krisvegh avatar Mar 26 '18 17:03 krisvegh

I found the issue.

The problem was that I have campaign / campaign in the path I want to access and library doesn't handle that properly. I marked it now as a bug.

This: https://github.com/angular-redux/form/blob/master/source/state.ts#L44

...indexOf will always find the first one.

krisvegh avatar Mar 27 '18 14:03 krisvegh

@krisvegh So did it work when you renamed one of the 'campaign'?

maplion avatar Apr 16 '18 19:04 maplion

@maplion Yes, it did.

krisvegh avatar Apr 17 '18 07:04 krisvegh

This is still a bug

prog-24 avatar Jan 01 '19 16:01 prog-24