password-strength icon indicating copy to clipboard operation
password-strength copied to clipboard

Angular 17 support

Open guillaume-moreau opened this issue 1 year ago • 19 comments

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

OS and Version?

Versions

Repro steps

ng update @angular/core@17 @angular/cli@17

The log given by the failure

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/cdk@"^16.x" from @angular-material-extensions/[email protected]
npm ERR! node_modules/@angular-material-extensions/password-strength
npm ERR!   @angular-material-extensions/password-strength@"16.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!

Mention any other details that might be useful

If needed I can provide a pull request.

Thank you :)

guillaume-moreau avatar Mar 07 '24 10:03 guillaume-moreau

I have the same problem in angular 17. I had to use npm install --force to skip this errors but personally i dont like this. I',m watching to downgrade my app to angular 16 to solve it.

jruizperalvo avatar Mar 08 '24 15:03 jruizperalvo

@AnthonyNahas Hi, Is there any plan to upgrade to angular 17 ?

Barrier-Theo avatar Apr 15 '24 13:04 Barrier-Theo

The lib works fine for me on angular 17 by forcing the dependency installation with '--force'. Tried sending an email to the lib owner a while ago, with no results unfortunately.

EDIT: looks like there was a commit last month upgrading part of the project to angular 17. So it looks like it'd be WIP.

jbellionjourdan avatar Apr 17 '24 18:04 jbellionjourdan

The lib works fine for me on angular 17 by forcing the dependency installation with '--force'. Tried sending an email to the lib owner a while ago, with no results unfortunately.

EDIT: looks like there was a commit last month upgrading part of the project to angular 17. So it looks like it'd be WIP.

Yup, but I would like to avoid using --force if possible.

guillaume-moreau avatar Apr 18 '24 07:04 guillaume-moreau

There is any news? I can't update my app until this will be resolve.

203876149 avatar May 09 '24 12:05 203876149

Waiting for the update as well

carlokid avatar May 17 '24 07:05 carlokid

Still waiting...

adamnik101 avatar May 29 '24 11:05 adamnik101

I have been waiting for these updates for a few months. Hey team, when can we estimate this update?

srsedev avatar May 30 '24 01:05 srsedev

I know things are never trivial, but since this is backwards compatible, shouldn't an update to the package.js file be all this needs? Even if there are improvements that someone wants to make, waiting like this can't be the best solution.

spbuda avatar Jun 04 '24 16:06 spbuda

Just a friendly nudge. Anyone here resorted to switch to an actively maintained alternative?

carlokid avatar Aug 09 '24 09:08 carlokid

On our side we remade our own password strength component :/ (we got a simple use case it was not a big amount of work)

guillaume-moreau avatar Aug 09 '24 11:08 guillaume-moreau

We've been using the --force flag, but intend to roll our own if we ever find the time. Don't have a lot of faith in this project promptly updating for future updates, even if the dev does finish this one.

spbuda avatar Aug 09 '24 14:08 spbuda

I might be willing to take over this lib and provide support for it, but it'd be my first published library so i need some time to figure out how it works.

I might have time in september, but no promises there.

jbellionjourdan avatar Aug 09 '24 14:08 jbellionjourdan

Ill upgrade to v17 soon

AnthonyNahas avatar Aug 11 '24 08:08 AnthonyNahas

waiting

MPalix86 avatar Aug 26 '24 09:08 MPalix86