google-maps-autocomplete icon indicating copy to clipboard operation
google-maps-autocomplete copied to clipboard

onGermanAddressMapped -> postalCode: NaN

Open mfrehe opened this issue 4 years ago • 2 comments

- [X] bug report
- [ ] feature request

OS and Version?

Ubuntu Linux 20.04 LTS

Versions

Angular CLI: 10.0.8 Node: 13.14.0 OS: linux x64

Angular: 10.0.14 ... animations, common, compiler, compiler-cli, core, forms ... platform-browser, platform-browser-dynamic, router Ivy Workspace: Yes

Repro steps

Just use the latest version and try to use the onGermanAddressMapped functionality with a non german address.

The log given by the failure

image

Desired functionality

Change type from number to string because the postalCode could contain other characters than numbers

mfrehe avatar Sep 21 '20 07:09 mfrehe

I have the same issue postal_code is coming to NaN for Canada address

mukeshj95 avatar Sep 30 '20 03:09 mukeshj95

as the name of the property isonGermanAddressMapped --> this object is typical for german addresses implemented...

a PR to improve multi countries is welcome

AnthonyNahas avatar Oct 12 '20 06:10 AnthonyNahas