generator-angular-fullstack icon indicating copy to clipboard operation
generator-angular-fullstack copied to clipboard

feat (*): Add i18n support

Open stherrienaspnet opened this issue 7 years ago • 10 comments

Add i18n support (multi-language) using angular-translate.

stherrienaspnet avatar Apr 05 '17 12:04 stherrienaspnet

Not sure how we merge in this project, but looks to me your commits don't follow the convention: -AngularJS commit message guidelines

benmarten avatar Apr 07 '17 21:04 benmarten

Can i change the PR text without cancelling it?

stherrienaspnet avatar Apr 07 '17 21:04 stherrienaspnet

I really your PR about warnings 😊

stherrienaspnet avatar Apr 07 '17 21:04 stherrienaspnet

If you mean how to rename your commits, look into 'git rebase -i HEAD~1'. the force pushing your local branch to remote, i guess ;) Renaming the PR itself should be possible here on GitHub itself...

benmarten avatar Apr 07 '17 23:04 benmarten

I forgot a word in my last posy , i mean I really your PR who fix warning message :)

stherrienaspnet avatar Apr 08 '17 01:04 stherrienaspnet

The missing word is like

stherrienaspnet avatar Apr 08 '17 01:04 stherrienaspnet

Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli

benmarten avatar Apr 08 '17 16:04 benmarten

Thanks Ben!

Le 8 avr. 2017 12:41 PM, "Ben Marten" [email protected] a écrit :

Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angular-fullstack/generator-angular-fullstack/pull/2534#issuecomment-292729568, or mute the thread https://github.com/notifications/unsubscribe-auth/AF19cfMUZbnm9u1--Fdqca-HkZoH3aWfks5rt7jMgaJpZM4M0MLN .

stherrienaspnet avatar Apr 09 '17 01:04 stherrienaspnet

I would really appreciate to have i8n support...

Ghalleb avatar Jun 23 '17 15:06 Ghalleb

is this working in the latest version?

saherrera avatar Aug 27 '18 23:08 saherrera