Adrien Gallouët
Adrien Gallouët
It works now :)
Why was visionOS not an issue before? The 0.27.0 version was also used just before the split commit 🤔
Instead of splitting maybe we can create a generic `http.h` limited to our requirements and simply include the complete, unmodified `httplib.h` file in a new `http.cpp` file that do the...
Hmm you sure? In both cases you only have one compilation unit to handle. Currently it’s very slow because every time we include `common.h`, we have to handle `httplib.h` as...
No, I meant that it was included in `common.h` before your split, so every compilation unit that included it had to recompile it before. I believe this was the primary...
> @angt the total compilation time stays unchanged. But each time I modify the code in server.cpp then recompile it, without having httplib in its own unit, it takes 24...
> * The SSL stuff is now embedded in all tools and examples increasing their binary size. We should build a shared `libllama-common` library As a quick fix, I can...
I'll refactor this PR after the merge of #17177
supersed by #17205
A first iteration could be to move `cpp-httplib` into a new `common/http.cpp` (instead of having only `http.h`) and add a minimal abstraction for both downloading and server functionality ?