nginx-autoinstall icon indicating copy to clipboard operation
nginx-autoinstall copied to clipboard

fix(pagespeed): update fqdn + instructions

Open sambacha opened this issue 5 years ago • 3 comments

this fixes the deadlinks for pagespeed, see apache/incubator-pagespeed-ngx/issues/1656.

Also added clearer instructions if pagespeed is used as a module so that users know to adjust their nginx.conf

sambacha avatar Mar 19 '21 15:03 sambacha

should fix the failing build on debian 9, just fixed the script, (was my error).

https://github.com/angristan/nginx-autoinstall/pull/180/checks?check_run_id=2149567703#step:3:9015

./configure: error: invalid option "To"

Additionally while examining the logs, these two issues cropped up:

apt-utils dependency: https://github.com/angristan/nginx-autoinstall/pull/180/checks?check_run_id=2149567844#step:3:334

debconf: delaying package configuration, since apt-utils is not installed

systemctl error: https://github.com/angristan/nginx-autoinstall/pull/180/checks?check_run_id=2149567703#step:3:9018

../../nginx-autoinstall.sh: line 597: systemctl: command not found

sambacha avatar Mar 19 '21 18:03 sambacha

Hello,

the patch doesn't work:

adding module in /usr/local/src/nginx/modules/incubator-pagespeed-ngx-1.13.35.2-stable
./configure: error: no /usr/local/src/nginx/modules/incubator-pagespeed-ngx-1.13.35.2-stable/config was found

angristan avatar Mar 19 '21 20:03 angristan

Hello,

the patch doesn't work:

adding module in /usr/local/src/nginx/modules/incubator-pagespeed-ngx-1.13.35.2-stable
./configure: error: no /usr/local/src/nginx/modules/incubator-pagespeed-ngx-1.13.35.2-stable/config was found

Targeting the build for 1.14.33.1-RC1 and not 1.13.35.2. It's your call obviously, but that version wont see any updates or backports to my knowledge. See this thread: https://github.com/apache/incubator-pagespeed-ngx/issues/1656

Will go ahead and make the requested adjustments, thank you.

sambacha avatar Mar 20 '21 10:03 sambacha