pyvex icon indicating copy to clipboard operation
pyvex copied to clipboard

Set build flags differently for release builds

Open rhelmot opened this issue 7 years ago • 9 comments

Right now all builds are -g -O2, which seems bad. We should probably have some good way to detect the build profile and switch between -g -O0 (maybe -g -O1?) and -Ofast or whatever other flags we want for release.

rhelmot avatar Sep 26 '18 22:09 rhelmot

+1

ltfish avatar Sep 26 '18 22:09 ltfish

Are we sure we need this? The only people that will likely be diving through pyvex code is us anyways, and we can make ad hoc changes to the flags in that scenario. Otherwise, I don't see why we ever want anything but -Ofast...

zardus avatar Sep 26 '18 23:09 zardus

Of course not, but I'd like my life to be a little easier...

rhelmot avatar Sep 26 '18 23:09 rhelmot

If you think you'll save more time building in build profile detection than changing the compiler flags when needed, then it makes sense of course. I'm not so sure that it'll amortize, though.

zardus avatar Sep 26 '18 23:09 zardus

if I cared about amortizing profits instead of doing the right thing at all times I would be living my life very very very differently...

rhelmot avatar Sep 26 '18 23:09 rhelmot

Hahahaha, fair point :-)

zardus avatar Sep 26 '18 23:09 zardus

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

github-actions[bot] avatar May 21 '22 02:05 github-actions[bot]

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

github-actions[bot] avatar Jul 22 '22 02:07 github-actions[bot]

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

github-actions[bot] avatar Sep 21 '22 02:09 github-actions[bot]