Angjelko Miloshevski
Angjelko Miloshevski
@chunhtai I will need a bit more time, as merging the latest commits from the main branch caused my example to have weird side-effects where the Hero animation doesn't work...
@chunhtai Sorry I am too busy at the moment with work, I will for sure complete it by the end of next week!
@chunhtai I can't complete the pull request until [#115832](https://github.com/flutter/flutter/issues/115832) its fixed, its blocking me. I could use a lower commit but still I would need to test it against the...
@ycherniavskyi yes saw the merge today, I will proceed with completing the PR
@ycherniavskyi the PR is ready waiting for @chunhtai to review it and approve it.
@arsen I will get on it tonight to finish it up.
@chunhtai as @ycherniavskyi suggested we should use the relevant HeroController based on whether MaterialApp or CupertinoApp is used, in order to do that we need to use the RouteBuilder not...
@chunhtai that's not what I meant, of course I would use isMaterialApp and isCupertinoApp, the situation is that creating the hero controller inside the RouteBuilder build method its not possible,...
@chunhtai I completed the PR, but the dart_unit_tests are failing, locally running the commands work ok, what am I missing here?
@ycherniavskyi Thanks for the suggestion, @chunhtai I added the cache solution, yes looks like CI is blocked