jdt-codemining icon indicating copy to clipboard operation
jdt-codemining copied to clipboard

[Improvement] Support for navigating to implementation

Open gayanper opened this issue 5 years ago • 6 comments

Today we can navigate to reference by clicking on it. But that is not available for implementations. Its will be some what complete if we can open the implementation popup when we click the implementations.

gayanper avatar Sep 04 '18 13:09 gayanper

If I understand your idea, click on implementation should open a popup like we have with Ctl+T. Is that?

angelozerr avatar Sep 04 '18 14:09 angelozerr

Yes exactly, but my doubt is we already have this "Open Implementation" when we CTRL+Click on the interface name as well.

gayanper avatar Sep 05 '18 02:09 gayanper

@angelozerr I started implementing this and while implementing found out that the count is shown based on the hierarchy of subtypes. But in eclipse searching to implementors/implementations give only the classes directly implementing the given interface. So don't you think its best to implement same as in eclipse search ?

ex: Fooable <- Foo <|-- Bar

in Codemining it consider both Foo and Bar as implementations of Fooable In Eclipse only Foo is considered.

gayanper avatar Oct 03 '18 16:10 gayanper

@mickaelistria, @vogella what do you think about that?

angelozerr avatar Oct 03 '18 16:10 angelozerr

@mickaelistria @vogella any update on this ? What do you guys think ?

gayanper avatar Oct 10 '18 13:10 gayanper

@gayanper I suggest you that you see https://bugs.eclipse.org/bugs/show_bug.cgi?id=541390

Now JDT hosts Java references, implementations code minings, I think your issue become important. It should very great if you could contribute to JDT with your work in https://bugs.eclipse.org/bugs/show_bug.cgi?id=541390

Thanks!

angelozerr avatar Nov 21 '18 09:11 angelozerr