ark-analysis icon indicating copy to clipboard operation
ark-analysis copied to clipboard

AnnData spatial analysis 1

Open camisowers opened this issue 1 year ago • 2 comments

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #1105.

How did you implement your changes

Assume that the user will use the AnnData conversion notebook once they have their completed cell table, and use this input for our spatial analyses computations. Functions that were changed to take only anndata_dir as input, rather than the cell table and distance matrix directory path:

  • calc_dist_matrix()
  • create_neighborhood_matrix()
  • generate_cell_distance_analysis()

Notebook updates:

  • kmeans (+ tests)
  • mixing score

Remaining issues

  • [x] Update notebooks
  • [x] test_utils function to add dist mats to AnnData table
  • [ ] waiting on new ark release

camisowers avatar Jan 25 '24 18:01 camisowers

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-l-kong @srivarra Can you guys just take a preliminary look? I'll do a second pass when the notebook tests are running.

camisowers avatar Feb 06 '24 19:02 camisowers