smart_account_creator
smart_account_creator copied to clipboard
angelol
Why limit to 12 characters?
Those winning namebid auctions will not be able to use your contract if you limit it to 12 characters. Soon enough, the namebid might open to more auctions also (Dan suggested one each 10 minutes for 6-12 characters).
In the mean time, you can let newaccount fail its assertions regarding name length.. Same with the symbol checks, you can let eosio.token fail its checks.
other notes while I'm rewiewing: "Not enough money" isn't clear enough :) It'd be better with a little bit of data as to what amount is missing, or something..
Also, you know if you charge a fee.. you'll be "forked out" of your own contract soon enough, right ? Someone is going to take the contract, make it fee-less and publish it.
Thank you, Alexandre, for taking the time to review.
Very good points. I will remove the 12 character limit and improve error messages a little bit.
Regarding fee, you're correct. It's on github, anyone can fork and deploy it and I'm fine with that. However, I needed a version of the contract with a small fee, so I can use it for my website, where people can buy accounts also with credit card and we provide customer support.
