capybara-page-object icon indicating copy to clipboard operation
capybara-page-object copied to clipboard

Published 20 hours ago • verified publisher icon andyw8

Added segmented path

Open ddidier opened this issue 11 years ago • 4 comments

ddidier avatar Mar 02 '13 14:03 ddidier

I think it doesn't make any sense to use magic comment in every .rb file if it's not needed.

abotalov avatar Mar 08 '13 10:03 abotalov

This pull request includes changes that were already declined in previous pull requests. You shouldn't include them again

abotalov avatar Mar 08 '13 10:03 abotalov

I'm sorry but:

  • at the time of writing that wasn't declined yet
  • I don't know how to make a pull request which depends on another one without including it (I searched the internet but only found that is was not possible...) ; but if you have a solution, I'll be glad to do it

ddidier avatar Mar 08 '13 11:03 ddidier

You should aim to to keep pull requests independent of each other so that the maintainer can choose which to merge, and the order in which to do so.

I suspect you might have branched form another of your branches rather than from master?

andyw8 avatar Mar 08 '13 15:03 andyw8