grunt-yslow icon indicating copy to clipboard operation
grunt-yslow copied to clipboard

Published 20 hours ago • verified publisher icon andyshora

Failed thresholds don't fail the task

Open kevindixon opened this issue 10 years ago • 0 comments

Looks like done() is always called without parameters, even in the case of a threshold not being hit. As such, the grunt task is always "successful". This means grunt-yslow isn't so useful in a CI setting where you'd want a build using grunt-yslow to fail.

Can I suggest the task should fail if there is a failing threshold?

kevindixon avatar Jan 27 '15 11:01 kevindixon