angularjs-table icon indicating copy to clipboard operation
angularjs-table copied to clipboard

Published 20 hours ago • verified publisher icon andyperlitch

Undocumented dependencies

Open pwarelis opened this issue 7 years ago • 5 comments

The documentation doesn't mention that this component depends on angular-ui/ui-sortable and that depends on jQuery. These two significantly bloat the resulting bundles.

Maybe make the sorting optional?

pwarelis avatar Nov 21 '17 17:11 pwarelis

Yes, making the sorting functionality sortable sounds fine. I should have some time today or tomorrow to make that change.

Thanks for the suggestion!

andyperlitch avatar Nov 21 '17 21:11 andyperlitch

Yikes, 22 days still... Apologies for the delay, I've been busier than expected. Will attempt to address this soon

andyperlitch avatar Dec 13 '17 18:12 andyperlitch

@pwarelis please have a look at #36 and tell me if that works for you.

andyperlitch avatar Dec 13 '17 23:12 andyperlitch

Hey Andy,

What about the module name 'ui.sortable' on angular module boot?

pwarelis avatar Dec 17 '17 14:12 pwarelis

Oh good call, will update the PR

andyperlitch avatar Dec 17 '17 23:12 andyperlitch