Andrew Nutter-Upham

icon location Cambridge, MA

Results 16 comments of Andrew Nutter-Upham

undefined method `join_keys' for class `ActiveRecord::Reflection::HasManyReflection' - ActiveRecord 6.1

This issue is already represented in the tests. ``` Finished in 17.77 seconds (files took 0.48395 seconds to load) 771 examples, 57 failures Failed examples: rspec './spec/integration/nested_has_many_through_querying_spec.rb[1:1:1]' # ScopedSearch using...

Override the max_index_name_size to keep local shortening algorithm. (8)

I like this idea, but just overriding the max only works for newer oracle versions and isn't sufficient for oracle 11. https://github.com/rsim/oracle-enhanced/commit/7b36a5ce0b125523157dcf16c36e0d917cf42c98

Override the max_index_name_size to keep local shortening algorithm. (8)

@davinlagerroos I believe I tried what you suggest here https://github.com/rsim/oracle-enhanced/commit/7b36a5ce0b125523157dcf16c36e0d917cf42c98 But it didn't bear out in the tests: https://github.com/rsim/oracle-enhanced/actions/runs/8509850693/job/23306215927 I would welcome a review. Thanks!

Override the max_index_name_size to keep local shortening algorithm. (8)

@davinlagerroos good idea! That has worked well and does a better job preserving existing behavior. I will rebase that into this PR tomorrow. https://github.com/andynu/oracle-enhanced/commit/696319271e666ff78eb6e46730bb8500509a80ff

Make insert return an array, and include the id_value if super returns nil (12)

Hi @mattalat 1. The Stack of PRs The purpose of the stack of PRs is to show passing tests along the way. That does mean that each one in the...

Support Rails 7.1 ColumnDefinition validations (5)

Thanks @davinlagerroos, your suggestion of overriding TableDefinition#valid_column_definition_options is a better approach. I've updated this PR accordingly.