Andrew Nutter-Upham

This issue is already represented in the tests. ``` Finished in 17.77 seconds (files took 0.48395 seconds to load) 771 examples, 57 failures Failed examples: rspec './spec/integration/nested_has_many_through_querying_spec.rb[1:1:1]' # ScopedSearch using...

I like this idea, but just overriding the max only works for newer oracle versions and isn't sufficient for oracle 11. https://github.com/rsim/oracle-enhanced/commit/7b36a5ce0b125523157dcf16c36e0d917cf42c98

@davinlagerroos I believe I tried what you suggest here https://github.com/rsim/oracle-enhanced/commit/7b36a5ce0b125523157dcf16c36e0d917cf42c98 But it didn't bear out in the tests: https://github.com/rsim/oracle-enhanced/actions/runs/8509850693/job/23306215927 I would welcome a review. Thanks!

@davinlagerroos good idea! That has worked well and does a better job preserving existing behavior. I will rebase that into this PR tomorrow. https://github.com/andynu/oracle-enhanced/commit/696319271e666ff78eb6e46730bb8500509a80ff

Hi @mattalat 1. The Stack of PRs The purpose of the stack of PRs is to show passing tests along the way. That does mean that each one in the...

Thanks @davinlagerroos, your suggestion of overriding TableDefinition#valid_column_definition_options is a better approach. I've updated this PR accordingly.

For ollama, thinking controls have been added to enable/disable thinking, and to hide the thinking output. https://ollama.com/blog/thinking

Yes! Thank you. On Tue, Mar 11, 2025 at 12:15 PM DanielClarke750 ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In activerecord-oracle_enhanced-adapter.gemspec > > :...

The VERSION should change too, but I'm not sure at what point in the PR process that is most appropriate.

That is how it used to be. But it appeared to have moved. Did it move back since? From the commit: Use the instrumenter method. @instrumenter is not defined. It...