Andy Nogueira
Andy Nogueira
Thanks @itsdevbear. @sergio-mena do you know if we have a mixed environment in our tests ? Do we test on Intel and ARM ? Looks like the benefits are dependent...
One concern that I have though is that this library seems to be a bit stale, [last commit](https://github.com/minio/sha256-simd/commits/master/) was February 2023. Maybe it's stable enough. But since we're replacing it...
Hi @ValarDragon, any updates on profiling these changes ? Please let us know when you have some results so we can decide if we will continue with this PR or...
> Yes! Been mildly delayed due to this breaking an api in the sdk, and our tooling messed up on both sdk and comet patches at once. Going to try...
That's amazing @ValarDragon, if it save 20GB of RAM 👀, please let us know if you re-profile I've added the code in all debugs. I've seen @cason comments that we...
Hi @ValarDragon, just following up here. Are these debug logs something you had a chance to validate in performance gains? Should we proceed with these changes? Please let us know....
Thanks for the follow-up @ValarDragon. I'll try to constrain this PR only on those places that are hot spots that you mentioned above and then mark it ready for review.
I'll close this PR. The implementation here is not the best way to solve the problem in #2847. I'm working on a new PR that has a better solution to...
Thanks for the pointer @hvanz, I'll take a look at that.
I've added the additional information about ABCI error to the tutorial in docs since it might be easier to find than the spec and we have also code in the...