Andy Nogueira

Results 82 comments of Andy Nogueira

Hi @TropicalDog17, seems it's failing on linting. Could you please check it ? For reference: https://github.com/cometbft/cometbft/blob/main/CONTRIBUTING.md#formatting--linting

I am working on some additional tests to ensure the logic holds and it makes sense

Just a quick update on this. I'm still doing some additional testing. The one I mentioned above was giving different results from other tests I'm performing with an "enhanced" kvstore...

> 👍 let us know when you're done with the extra tests and I'll take another look Hi @sergio-mena, I've added an extra test `Test_V1Beta2_ABCIResponses_To_FinalizeBlockResponse` which un-marshalls the binary file...

Just an update, still working on this, need to add some additional testing to ensure these changes are good especially backporting to old releases. But hopefully should be ready to...

Just an update. The fix is still on-going. We believe we have a solution but might be hard to test with live production data (archive nodes). Would anyone that benefits...

Hi @mbreithecker and @jhernandez, I made some changes a few days ago, including the attributes logic suggested. Do you need to test this on a v0.38 level branch, or are...

> I made some changes a few days ago, including the attributes logic suggested. Do you need to test this on a v0.38 level branch, or are you okay with...

> @andynog can we merge this now since this patch was verified? Hi @melekes, I believe we are almost good to merge since we got a couple of confirmations that...

Hi @mbreithecker, @mmsqe, @johnletey, @jhernandezb and @SpicyLemon This fixed has been back ported to `v0.38.x` (#3435) and it will be available in the next release in the `v0.38` line. Thanks...