Doesn't work with latest PresentMon versions

[eddr]

trafficstars

Hi

I get a general error message. Running via command line works fine, but via the launcher, the closing click (second time I click Ctrl+Shift+L) results in an error message. Tried 1.0 and 1.1 versions General error message: http://imgur.com/a/8ZqIu

Tried the following versions: The 1.12 release file you referred me to + the one from the PresentMonLauncher package + compiled the sources myself (got a 2.7MB file), but maybe I didn't do it right somehow?

Windows 10 1703, latest Nvidia drivers (even removed and reinstalled). No other problems. Every 3D application and game works fine

Worked fine till 2-3 months ago. Not sure what changed. That's the third laptop I have problem with (various models and brands, if that matters)

Can I provide somehow more debug info?

[andymanic]

Interesting - what is the system spec?

I've never had the actual launcher crash on me before. What settings did you have it on (timer/delay etc)? Does it corrupt the PresentMon file? What game(s) does it crash on?

[eddr]

Thanks

1. file was not created
2. default settings - didn't change a thing
3. Tried Hitman, doom, BF1, Rise of the Tomb Raider - their non DX11 options
4. Acer Helios 300, I7-7700HQ, GTX 1060 6GB, latest drivers. But happened on the Lenovo Y720 (7700hq, gtx 1060) and Acer VX5-591G (i5-7300HQ, GTX 1050)

[andymanic]

Can you try running with a timer? That way I can narrow the issue down.

[eddr]

Nothing happens - file not created but there is no error message either (and the program doesn't close). Set it on 4s and pressed Ct+Sh+L

[andymanic]

Interesting. I'll check out the code/files and see what the problem is, although nothing has changed in the last while besides me re-packaging the launcher with the latest version of PresentMon... Will have a look.

[eddr]

Just checked - it works with v1.0 and the new PresentMon 1.12 binaries BTW, installing the package as it is results in an error message saying that the "msvcp140d.dll" missing. Maybe you should include the binaries that include it?

[andymanic]

I had a look, ran tests myself and couldn't find an issue nor replicate yours. I did however re-package the latest PresentMon V1.1.2 (renamed to PresentMon64.exe due to our program design searching for that specific file name on launch) which may help - give this a shot and let me know the outcome. (It's an EXE in a ZIP due to Github's attach files limitations... sorry.) PresentMonLauncher Installer.zip

[andymanic]

In regards to MSVCP140D.dll that is a VCRedist_x86 file that should already be installed - I run into that problem running some games on new systems. Install these and see if the problem persists: https://www.microsoft.com/en-us/download/confirmation.aspx?id=21254 https://www.microsoft.com/en-us/download/confirmation.aspx?id=5555

[eddr]

Thanks

1. It install the old launcher? because it says v1.0
2. Perhaps something with the 1703 update - didn't have this problem before. I'll test soon

[andymanic]

Ah yes, appologies that was the wrong final build, but besides the version number all the code is still the same. It's very possible, as Windows is constantly breaking ETW...

[eddr]

Tried to open the solution file with VS2017 with no success - nothing is loaded. Haven't use VS for ten years, maybe I'm doing something wrong?

Thought about adding maybe a graph utility

[h0rnman]

I'll have to look tomorrow but I bet it has something to do with the hotkey triggering the stop action. My guess is that you would get the same behavior out of clicking the start button twice. Can you look at the logic and see if we're actually getting the process handle for presentmon correctly. If the new version uses a different exe name in task manager, then we might be trying to terminate it without actually having a reference to it.

On Jul 25, 2017 2:30 PM, "andymanic" [email protected] wrote:

Ah yes, appologies that was the wrong final build, but besides the version number all the code is still the same. It's very possible, as Windows is constantly breaking ETW...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/andymanic/PresentMonLauncher/issues/25#issuecomment-317846826, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlGATAfpX8HZPerlSgcsfwUa1chgVNiks5sRkJUgaJpZM4OirHU .

[h0rnman]

I think I found it, but don't have my development environment set back up yet. Andy, can you change PresentMonLauncher::stopbutton_Click to this:

        private void stopbutton_Click(object sender, EventArgs e)
        {
            if ( (PresentMon64 != null) )
            {
                if (IsRecordingManually == true)
                {
                    PresentMon64.Kill();
                    IsRecordingManually = false;
                }
                else
                {
                    PresentMon64.Kill();
                }
				
				PresentMon64 = null;
            }
            else
            {
                //had to add this to solve the issue of the user pressing stop twice and breaking the program
                return;
            }
            System.Media.SystemSounds.Beep.Play(); //I tried doing this in a function of it's own but it wasn't worth the pain.
        }

[eddr]

so it's dead?