Andy Lok

Results 108 comments of Andy Lok

> not sure I understand your thread workaround example https://github.com/tikv/minitrace-rust/issues/117#issuecomment-1070913840. As best I can tell it is not possible to move the thread::spawn() inside do_stuff(). Correct? Do you want this:...

Local span is not `Send` which will make the `Future` not able to spawn into a multi-threaded runtime. So it may be not usable in the real world.

I suspect that the plugin mistakenly set `cfg(test)` to `true` for doctest.

How long will the pipeline refactoring take? Since such subtle cases rarely exist in a practical project (let's say TiKV and RisingLightDB), I think it's not too urgent to fix....

I agree to use `cfg` to minimize/remove the performance impact.

I appreciate you bringing these up. I haven't been able to come up with an *overwheelming* better design. But I could exhibit some ideas behind the current design for later...

> To clarify: You'd like there to be consistency, by default, in the number of spans generated by one call of a sync function and and one call of an...

> What is the use case/scenario where having async functions appear once adds value? The first request that I know so far is https://github.com/tikv/minitrace-rust/issues/64#issuecomment-936271952