Andy Jordan

Results 495 comments of Andy Jordan

Ok, I installed Emacs on my machine and have (to be honest) really missed it, so I will try to get `lsp-mode` fixed. I think its variables for directory paths...

Perhaps we should prioritize dumping Serilog 🤔

Hm very interesting, especially since we apparently use vastly different versions: https://github.com/PowerShell/PowerShellEditorServices/blob/da481f250473df2c7c87de445d20593803ee7b4d/src/PowerShellEditorServices/PowerShellEditorServices.csproj#L31 https://github.com/PowerShell/PowerShellEditorServices/blob/da481f250473df2c7c87de445d20593803ee7b4d/src/PowerShellEditorServices/PowerShellEditorServices.csproj#L36

> I probably could have removed it in less time than I've spent debugging this. I would 💯accept a PR replacing Serilog @dkattan, looking into it myself.

@sandy081 this has started breaking our extension's tests without warning, and moreover, the way it writes to `package.json` it's modifying the whole file (looks like whitespace changes).

@hyangah how have you gone about working around this breaking change? I'm trying to get a release out myself and am suddenly blocked 😭

Whelp, something else went on that broke my tests, but definitely noticed this too and will need to be careful about not committing the reformatted `package.json`.

I'm currently reverting it. Would love to know if we should do otherwise.

Related, similar feature request: https://github.com/PowerShell/vscode-powershell/issues/3048

Also related to https://github.com/PowerShell/vscode-powershell/issues/3902.