polypage icon indicating copy to clipboard operation
polypage copied to clipboard

PolyPage 0.8.3 and IE7

Open tinytina opened this issue 15 years ago • 5 comments

Just downloaded 0.8.3 and tried to run the demo you provided. Anytime I click on one of the triggers at the top, it simply adds "#pp_toggle_admin" to the url. Works in FF3, Opera 9, Chrome, but not IE No surprises there, I guess, but the demo you have posted at http://code.new-bamboo.co.uk/polypage/ does work...

tinytina avatar May 13 '09 20:05 tinytina

Eeek! Thanks, I'll take a look into this, this week.

andykent avatar May 21 '09 09:05 andykent

Any updates on this working with IE7? It does work with IE8 (again, no surprises that IE is wonky), but not IE7.

tinytina avatar Jul 15 '09 19:07 tinytina

this is an issue with triggerEventFromHash in events.polypage.jquery.js

replace line 42 if(hash.search(/^#pp_/)==-1) return false; var hash = hash.replace(/^#pp_/,'');

with if(hash.search(/#pp_/)==-1) return false; var dummyhash = hash.split("#pp_"); var hash = dummyhash[dummyhash.length - 1];

works for me

sionnnn avatar Nov 04 '09 16:11 sionnnn

sionnnn's change works for me. Thanks sionnnn!

smt avatar Jan 25 '10 17:01 smt

Just in case anyone else comes across the same issue, I think there should be an underscore after all instances of #pp in sionnnn's code. Github comments seem to strip them out.

maban avatar Apr 25 '12 10:04 maban