Andy Keller

Results 27 comments of Andy Keller

This is working as intended per the Connection interface: https://github.com/open-telemetry/opamp-go/blob/3f2eab449870fb6ed667fc55a205a68bf97a0935/server/types/connection.go#L16-L21 I will do some benchmarking with a large number of connections to determine the overhead of adding a mutex per...

I proposed an implementation in https://github.com/open-telemetry/opamp-go/pull/53 using ServerToAgent.Flags

With the OpenSearch project in full gear, I don't see this being a priority, but I managed to build a docker image on m1 for an old build (1.10.1) and...

@tigrannajaryan Let me know what you think of this direction.

I realized overnight that we should add a hash so it is clear that the response is appropriately associated with the last message. I also stubbed the client callback, which...

Closing while spec is being finalized and discussion is happening in the spec repo.

> @andykellr please take a look, I believe you wanted this capability. This will be a good addition. I agree with your feedback. The http Close() is a strange case....

> I think Disconnect() is a better name and it is fine to make it an error to call Disconnect() for plain http connections. I was going to suggest that...

I think we agreed in the last meeting that we should make this change.

While investigating this issue, many of the references I found regarding frame size limits refer to the 32K limit in AWS API Gateway. > Because of the WebSocket frame-size quota...