Andy Jiang

Results 35 comments of Andy Jiang

Added some comments and addressed initial reviews. @loriab @jturney feel free to take a look

Pinging @loriab once again, requesting review

@davpoolechem No reason, I would prefer a review from @loriab, but it is not necessary

@loriab @jturney PR is ready for merge, after all tests pass!

I have the code cleaned up enough to where it is ready for review! Requesting reviews from @loriab and @jturney!

Try the macro `PSI_ZERO` for machine precision (See https://github.com/psi4/psi4/blob/master/psi4/include/psi4/psi4-dec.h#L52)

> @andyj10224 To respond to your suggestion about the location of the coefficients: I also don't like all the coefficients there, but they were made to solve this specific problem,...

@NathanGillispie Let me know once you add docs, so I can approve this PR! Also make sure to rebase this with the main branch :)