valent icon indicating copy to clipboard operation
valent copied to clipboard

Message threads will become corrupted while loading while switching

Open coreyoconnor opened this issue 8 months ago • 5 comments

Current Behavior

  1. clear cache (not required?)
  2. open messages
  3. while threads are loading: switch current thread

Expected Behavior

expectation is that even if the user is switching between current threads should not result in the state of threads being corrupted. The state of threads should not be effected by switching the current threads.

Desktop

GNOME Shell

Other Desktop

No response

Operating System

NixOS

Installed from

Built from source (Other)

Version

nightly

Devices

No response

Plugins

gnome

Logs

TBD the log I had contained PII

Screenshots

No response

coreyoconnor avatar Apr 19 '25 00:04 coreyoconnor

Hi, can you clarify what you mean by "corrupted"?

andyholmes avatar Apr 21 '25 19:04 andyholmes

The corruption I've been observing is: Message added to the wrong thread.

EG: A thread for number 123-5455 will get messages added to it that should have gone to thread for number 888-8888.

Another "corruption" I've observed is blank messages being added to threads.

I wish I had screenshot of these that did not have PII. I'll see if I can mask out some stuff and still communicate the oddness.

coreyoconnor avatar Apr 21 '25 20:04 coreyoconnor

Is this fixed if you close and open the window? If not, is it fixed if you stop and restart Valent after observing this?

In other words, is the corruption UI-based in nature or do you think the underlying database is being corrupted?

Blank messages might be a red herring for this issue; there are some occasions Android will omit TOTP codes, RCS messages, images, etc.

andyholmes avatar Apr 21 '25 20:04 andyholmes

An example of one type of "corruption". The selected thread is "20..." while the number for the thread is "(30...". Which is a number for a different thread.

Image

This is not what I described before. Just another I ran into trying to reproduce what the issue from above. I've deleted ~300 SMS from my phone recently. That might effect this. Right now (using git HEAD) I'm having no luck reproducing the case where messages are in the wrong thread.

coreyoconnor avatar Apr 22 '25 04:04 coreyoconnor

Right when I thought I would be unable to repro this after deleting messages: Found a case.

This persists across application restarts. The screenshot is redacted but hopefully shows the issue:

  • the 93.. number shows up twice in the thread list
  • the current thread is 93.. but it is showing messages from (314)... and 93...
  • The second 93.. similarly shows messages from 93.. and another number.

Image

coreyoconnor avatar Apr 23 '25 17:04 coreyoconnor