go-jira icon indicating copy to clipboard operation
go-jira copied to clipboard

Published 20 hours ago • verified publisher icon andygrunwald

Added issue link

Open Fank opened this issue 2 years ago • 1 comments

What type of PR is this?

  • feature

What this PR does / why we need it:

It adds the missing issue link

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

Fank avatar Oct 27 '22 12:10 Fank

Thanks for this Pull Request @Fank. This is looking pretty good already!

A few things, that came into my mind:

Own Service

I am not 100% sure if we should run our own service here or consider making this part of the IssueService. IssueLinks are pretty coupled to Issues. And the IssueLinkService would be pretty small (only 3 methods). I don't have a correct answer for me right now, just a thought.

Existing methods

In issue.go, we have already a few IssueLink API methods:

  • https://github.com/andygrunwald/go-jira/blob/aea7aec6b799e6f614153a8e89939726648a4098/cloud/issue.go#L735
  • https://github.com/andygrunwald/go-jira/blob/aea7aec6b799e6f614153a8e89939726648a4098/cloud/issue.go#L1022

They are (still) a wild mix between On-Premise and Cloud, but I would consider removing those already.

Moving forward

Let me know your thoughts. I can make the changes myself, while merging this into in the next couple of time/days.

andygrunwald avatar Oct 30 '22 08:10 andygrunwald