go-jira icon indicating copy to clipboard operation
go-jira copied to clipboard

refactor: Replaced github.com/pkg/errors with errors

Open Fank opened this issue 2 years ago • 2 comments

Description

Please describe what does this Pull Request fix or add?.

It replaces the obsolete module github.com/pkg/errors with the official one errors which got introduced in golang 1.13

Information that is useful here:

  • The What: What is your change doing?
  • The Why: Why is your change useful/needed? What is your use case? (this helps us to understand the real world better)
  • Type of change: Things like Bugfix, New feature, Code quality improvements, Dependency upgrade, Documentation, ...

Code quality improvements

  • Breaking change: Yes or no? Backward compatible?

No

  • Related to an issue: Does this fix or close an issue? Or is related in any kind?
  • #200
  • Jira Version + Type: Which Jira version and type (on-premise / cloud) you have used?

Cloud

Example:

Let us know how users can use or test this functionality.

// Example code

Checklist

Fank avatar May 31 '22 09:05 Fank

Thank you @Fank! I have limited time at the moment, hence my review will take a while.

Would you mind checking the tests in the meantime? That would be very nice!

andygrunwald avatar Jun 04 '22 07:06 andygrunwald

Should be fixed now

Fank avatar Jun 07 '22 10:06 Fank

FYI: https://github.com/andygrunwald/go-jira/issues/478

andygrunwald avatar Aug 20 '22 16:08 andygrunwald

Hey,

I am very sorry that this pull request has been open for a long time with no final feedback or merge/decline. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in https://github.com/andygrunwald/go-jira/issues/489

The development will take some time; however, I hope you can benefit from the changes. If you seek priority development for your pull request + you like to sponsor it, please contact me.

What does this mean for my pull request?

We will work on this pull request indirectly. We might merge it during the development or pull parts of it into the new version. This means that during the development phase, we aim to tackle it. Maybe in a different way like it is currently handled. Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using and contributing to this library. If there is anything else you would like to tell us, let us know!

andygrunwald avatar Aug 21 '22 15:08 andygrunwald

This change is related to https://github.com/andygrunwald/go-jira/issues/478

andygrunwald avatar Aug 21 '22 16:08 andygrunwald

I like this change. Thanks a lot @Fank!

This will go directly into v2

andygrunwald avatar Aug 21 '22 16:08 andygrunwald