go-jira icon indicating copy to clipboard operation
go-jira copied to clipboard

Published 20 hours ago • verified publisher icon andygrunwald

Inconsistent time fields

Open kfoxb opened this issue 5 years ago • 6 comments

I've noticed that there are some fields on some of the types, in particular the Comment struct, that are strings instead of a jira.Time. Is there a reason for this? It would be a breaking change, but would you be open to a pull request to change these fields to be jira.Time instead?

kfoxb avatar Mar 31 '20 19:03 kfoxb

Another option (avoiding a breaking change) would be to at least implement helper methods similar to ChangelogHistory.CreatedTime.

bored-engineer avatar Apr 29 '20 06:04 bored-engineer

@kfoxb The reason might be that jira.Time was introduced later and not fully adjusted to all types. Indeed, this would be a breaking change. And maybe it is time for a breaking change + v2. We have more and more such changes.

Would you be open to prepare such a PR to make it consistent across the library?

andygrunwald avatar May 02 '20 21:05 andygrunwald

I have a more general question regarding how to use/access/cast of the Time data? https://stackoverflow.com/questions/61897115/fail-to-access-cast-time-time

perolo avatar May 19 '20 17:05 perolo

I was so sure that I tested and failed with: resDate=time.Time(issue.Fields.Resolutiondate) But that solves my problem ....

perolo avatar May 19 '20 21:05 perolo

This issue has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 19 '20 04:07 github-actions[bot]

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in https://github.com/andygrunwald/go-jira/issues/489

The development will take some time; however, I hope you can benefit from the changes. If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly. This means that during the development phase, we aim to tackle it. Maybe in a different way like it is currently handled. Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library. If there is anything else you would like to tell us, let us know!

andygrunwald avatar Aug 21 '22 14:08 andygrunwald