Andy Grunwald
Andy Grunwald
It contains invalid json. How to reproduce: 1. Go to your marathon-tasks definitions 2. Create a file `fail.json` with the content ``` { "id": "/my/id", } ``` 3. Save it...
Just Reopening this. I think there are a few good ideas in this PR. Right now, my time is pretty limited, still, I plan to come back to this.
Will come back to you once i tested everything with v1.4
I looked deeper into this PR and created https://github.com/lansuite/lansuite/pull/634 as a follow-up. This PR goes in the right direction but has three small flaws: 1. LanSuite is not compatible with...
@M4LuZ Is this still valid? Do you plan to rebase / re-pick this up and update it? Just raising the question before I jump into a review.
@M4LuZ Is this still valid? Do you plan to rebase / re-pick this up and update it? Just raising the question before I jump into a review.
@M4LuZ I am planning to go through the open Pull Requests and see which one we can finish/merge and get value from or which one we should abandon and close...
@M4LuZ Ok. Let me know once this is ready again for review.
@M4LuZ I had a quick look at it and did: * Included the last stable version and not the development version: https://github.com/lansuite/lansuite/pull/292/commits/d8c4ea6ae2fa3a5f6d92852dcbacb47543bd3143 * Fix inclusion of the classes: https://github.com/lansuite/lansuite/pull/292/commits/f5024c52b372e2a865d1b59042b3f3600062fbfd *...
First, thanks a lot for this Pull Request. I updated the branch, and I was reading through this issue. It is a significant change in the right direction. Here are...