scala-jsonschema icon indicating copy to clipboard operation
scala-jsonschema copied to clipboard

dependencies cause failure to compile (or start sbt)

Open jwgcooke opened this issue 2 years ago • 8 comments

Describe the bug External doc dependencies are out of date and no longer appear to be supported. Trying to compile the project results in a dependency issue :

[error] 	* org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over {1.0.6}
[error] 	    +- org.scoverage:scalac-scoverage-reporter_2.12:2.0.1 (depends on 2.1.0)
[error] 	    +- ws.unfiltered:unfiltered_2.12:0.9.1                (depends on 1.0.6)
[error] 	    +- org.foundweekends:knockoff_2.12:0.8.6              (depends on 1.0.6)

This is in due to the plugin sbt-paradox-material-theme being very out of date and apparently no longer maintained

To Reproduce Download source into a clean clone, execute sbt, fails to start sbt

Expected behavior sbt should start and code should be able to be compiled

Actual results sbt fails to start with dependency exceptions

Versions: Scala 2.13.8 Json Schema version : not relevant

Additional context Add any other context about the problem here. using sbt 1.7.1

jwgcooke avatar Aug 19 '22 17:08 jwgcooke

this is a nice catch. thank you

andyglow avatar Aug 19 '22 17:08 andyglow

@andyglow - is the doc stuff around paradox being used at all? All of the dependency issues are in there. Is there any reason to not just pull it all out? I can create a PR for it if that is ok with you.

jwgcooke avatar Sep 13 '22 15:09 jwgcooke

hello, the paradox docs are supposed to replace readme at some point.. it's just a question of free time to get them updated and published.. unfortunately last year I had no time for this if you have bandwidth, please go ahead any help appreciated

if i remember well somehow I could not make the documentation part of the build which was a goal I wanted to use sbt-paradox with material-theme and also with mdoc for documented snippets to be verified and evaluated there is a documentation branch that should host all the corresponding changes

andyglow avatar Sep 13 '22 21:09 andyglow

the material theme does not appear to be actively maintained. The library versions that back it are all out of date and there have been no commits in 4 years. I will look at what you have own the branch and see if I can make sense of it.

jwgcooke avatar Sep 13 '22 21:09 jwgcooke

Not sure which is the "documentation" branch?
image

jwgcooke avatar Sep 13 '22 21:09 jwgcooke

ohh.. I'm sorry. Yes, you're right.. I just never pushed it before but you can find it there now.. it's halfway done though, so expect not everything is working there thanks so much for looking into this

for the material theme.. you know better alternatives? or otherwise, may be it's the case when if it works it works? :)

andyglow avatar Sep 16 '22 00:09 andyglow

Looked at the material theme issues. There are 3-4 PRs with updated libraries mostly around Circe and the fact that it is breaking things. Jonas ( the owner) does not appear to be responding to any of it. I created a new one but it might be better to fork it, rename it, credit Jonas and make use of it that way? This is only really an issue if you really feel the need for the material theming of course. All of the doc libraries are in weird states. Even Paradox does not has a Scala 2.13* release. There is a short term fix to comment out the doc libraries which will allow for a build to pass (and the PR from justcoon to build correctly). I would start with that and tackle the documentation as a separate issue. Does this work for you?

jwgcooke avatar Sep 26 '22 20:09 jwgcooke

Hi, Gordon @jwgcooke Sorry for looong reply. Really busy at work.. Answering your question - yes, please go ahead and comment it out.

andyglow avatar Oct 17 '22 23:10 andyglow