Andy Ferris comments

Results 396 comments of


                                            Andy Ferris

Getting a goals list

> Considering how many parts of the Julia ecosystem are built on StaticArrays Also not one of the people on the list, but I thought I might note there are...

Use Base.promote instead of promote_tuple_eltype to fik promotion

Cool. Did you look into performance of `promote(x...)`? Interesting corner cases to consider include `Union` element types, or longer tuples, or both. Certainly we wouldn't want generated code to regress...

Use Base.promote instead of promote_tuple_eltype to fik promotion

> probably because the generated function `promote_tuple_eltype` can't handle types defined later than itself. This is confusing, right? The function generator doesn't currently call `promote_type` at all... it generates code...

Use Base.promote instead of promote_tuple_eltype to fik promotion

lol, nice archaeology. Constructors were done first - promotion behaving like other arrays obviously being pretty important. How time flies :)

Use Base.promote instead of promote_tuple_eltype to fik promotion

In any case we should double check some generated (native) code first but in general I am in favour of removing generated code.

Element type of `Diagonal{T}` is `T` even when `typeof(zero(T)) != T`

Sometilmes I feel that `eltype` could be more of a trait for `AbstractArray` (or `iterate`, I suppose?). It makes sense as a type parameter of `Array` but I've noticed that...