AcceleratedArrays.jl icon indicating copy to clipboard operation
AcceleratedArrays.jl copied to clipboard

Published 20 hours ago • verified publisher icon andyferris

Typo in `isgreater`

Open tpgillam opened this issue 1 year ago • 0 comments

https://github.com/andyferris/AcceleratedArrays.jl/blob/a77ffdee3bd1c15bcf12d731d09a579d9ef1a0b2/src/predicates.jl#L40-L42

Should be isgreater(a, b) = isless(b, a).

It's correct in the README though!

https://github.com/andyferris/AcceleratedArrays.jl/blob/a77ffdee3bd1c15bcf12d731d09a579d9ef1a0b2/README.md?plain=1#L120

In practice I think the tests don't catch this because they're only looking at the implementations of findall and findlast for these on UniqueSortIndex, which doesn't actually depend on the implementation.

tpgillam avatar Mar 12 '23 20:03 tpgillam