Intl.js icon indicating copy to clipboard operation
Intl.js copied to clipboard

IE8 compat

Open caridy opened this issue 9 years ago • 6 comments

In the past, this polyfill worked fine with IE8. Currently, we are getting two issues in IE reported by travis, as a result, we get tons of failures during the CI process. Here are two examples of the two different issues:

--FAILED-- intl402/NumberFormat/11.4_a.html { browserName: 'internet explorer', version: '8', platform: 'Windows 7', prerun: 'http://localhost:8000/tests/ie8fix.bat' } 'IntlPolyfill' is undefined
--FAILED-- intl402/NumberFormat/6.3.1_a.html { browserName: 'internet explorer', version: '8', platform: 'Windows 7', prerun: 'http://localhost:8000/tests/ie8fix.bat' } Object doesn't support this property or method

Those files are generated in tests/test262/pages/intl402/, example: tests/test262/pages/intl402/NumberFormat/11.4_a.html

More details about the failures here: https://travis-ci.org/andyearnshaw/Intl.js

caridy avatar Jun 16 '16 23:06 caridy

If someone has as IE8 at hand, and can help with this, that will be great.

caridy avatar Jun 16 '16 23:06 caridy

ping! can someone help on this?

caridy avatar Jul 01 '16 16:07 caridy

I have a problem in Safari 8 It's not happen all the time. Just few refresh and below error shows up

"Can't find variable: IntlPolyfill"

image

chaintng avatar Jul 31 '16 11:07 chaintng

@chaintan17 certainly not related to this issue, which is about IE8. I wonder how are you loading the polyfill? could this be a race condition in the way you load it? Please, feel free to open a new issue.

caridy avatar Jul 31 '16 17:07 caridy

Oh, it's racing condition, yes. Thanks for your info @caridy

chaintng avatar Aug 01 '16 03:08 chaintng

I'll try and get some time to look into this soon. In the past, I've used SauceLabs to manually run the test to figure out what's going on, so I'll maybe do the same. I think we might have an IE 8 machine around work somewhere too so I can give that a try.

andyearnshaw avatar Aug 01 '16 08:08 andyearnshaw