Use tls.Dial() when forwarding a connection to a proxy with TLS configured

Open jjcollinge opened this issue 5 months ago • 3 comments

This PR is fixing the failing tests from the PR which is now stale as @tscolari is no longer working on this.

I updated it to move client_tls to tls.client based on the discussion in the issue.

Oct 27 '25 10:10 jjcollinge

@andydunstall Hey, let me know if you have any feedback you'd like me to address.

Nov 03 '25 15:11 jjcollinge

@andydunstall thanks for the feedback, updated. I also needed to add the server name to the TLS config so that you can set it to use the expected hostname from the certificate instead of just the IP.

Nov 11 '25 11:11 jjcollinge

@andydunstall nudge

Nov 25 '25 14:11 jjcollinge

@jjcollinge Sorry for the delay! (Again!)

I've moved jobs so no longer checking GH regularly, and found my email notifications have been disabled (will fix to get notifications properly)

This looks good thanks!

Dec 09 '25 08:12 andydunstall