gbajs2 icon indicating copy to clipboard operation
gbajs2 copied to clipboard

Support mobile

Open keicoon opened this issue 4 years ago • 5 comments

Add Some feature for mobile

  • Add mobile.index, npm server.js , mobile-css file
  • Virtual Pad ( TODO: use canvas, not button dom )
  • Fix bug in util Serializer
  • Using https ( for Accessing save and load file )

Thanks :)

keicoon avatar Dec 27 '20 11:12 keicoon

Test is success in safari for ios , chrome for ios :)

keicoon avatar Dec 27 '20 11:12 keicoon

Sorry for the delay in reviewing this.

First of all huge thanks in doing this work, I'm extremely grateful for the time spent here.

I'm going to merge this to a new branch called "mobile"

Some feedback:

  • What do you think about trying to reconcile the desktop and mobile versions of the application? I personally believe in progressive enhancement so having one page that supports both mobile and desktop.
  • What's the advantage of adding an express server? Trying to keep things simple but if there's a good reason to include it then I understand

andychase avatar Jan 10 '21 21:01 andychase

I merged your PR into the mobile branch

andychase avatar Jan 10 '21 21:01 andychase

Hello, thanks for your work. if have I want to play this version, should I deploy by myself?

chunibyo-wly avatar Mar 30 '21 05:03 chunibyo-wly

@chunibyo-wly yes right now I haven’t merged this onto the website, mostly because I would have to the express dependency for it to work with GitHub pages

andychase avatar May 17 '21 00:05 andychase