Andy Balaam

The test failures appear to be https://github.com/testing-library/dom-testing-library/issues/1234

> The test failures appear to be [testing-library/dom-testing-library#1234](https://github.com/testing-library/dom-testing-library/issues/1234) A fix for that appears to be in progress.

Work will continue on this in January

Prerequisite: https://github.com/matrix-org/matrix-analytics-events/pull/76

i18n test is failing with > fatal: couldn't find remote ref andybalaam/favourite-messages-rebased which I don't understand

OK, CI seems happy so requesting a re-review from @t3chguy

> OK, CI seems happy so requesting a re-review from @t3chguy Scratch that - techguy is too busy today so I'll ask someone else.

> If I read correctly, this will save all favorite message ids in a single account data entry (`favourite_messages` with element settings prefix). The downsides of this approach would be...

> > Note: that MSC proposes using Room Account Data, but I plan to use general Account Data because I think favourites should not be tied to rooms. > But...

> This is the last one for today. And maybe I am too picky here, but it hurts me upside_down_face The header design for favourite message is not the same...