Andy Alt

Results 158 comments of Andy Alt

@Phantsure I think I could handle this ticket if you wanna reassign it.

Do you want this added? Either the [errors it found](https://github.com/widelands/widelands/pull/5342/checks?check_run_id=5778976244) could be fixed in a separate PR, and afterward this branch could be rebased before merging. Or maybe it would...

> Since you're contributing quite a lot to Widelands, please also add yourself to the `data/txts/developers.json` :) Thanks!

For anyone interested, docs for running codeql from the command line are at https://codeql.github.com/docs/codeql-cli/creating-codeql-databases/

> in the test suite the scan results of codeql is finished after 2 seconds while the check is still running. maybe there is a depends missing. I'm a bit...

I've opened a PR on my fork that adds the codeql analysis file but doesn't introduce any fixes. The results should be at https://github.com/andy5995/widelands/pull/2/checks?check_run_id=5844248996 It should soon show all original...

Tests now failing. Why is this happening? https://github.com/widelands/widelands/runs/5844695311?check_suite_focus=true#step:5:1305

rebased at https://github.com/widelands/widelands/commit/b2addfc83a51e1f0d27a5a33831e8a439a077b20

> @andy5995 do you still want to work on this. At this time, no.

One thing to consider is that in shell and CMake scripts, the nested levels of indention don't get too deep, so having two spaces for indentation (and not being able...