Andrey Kutejko comments

Results 67 comments of


                                            Andrey Kutejko

favicons seem to never call back in some cases

@peksipatongeis may you try to reproduce the issue with favicons 7.0.0-beta.4?

favicons seem to never call back in some cases

I was not able to reproduce this on Linux, but somehow this happens from time to time on Windows virtual machine. I am afraid, this is some sort of low-level...

Always generate manifest.json?

@johndeighan See #368

No files being created?

Addressed in #422

Disabling manifest still inject manifest in html

`output` option is kinda a low-level one. You probably need to disable generation icons for `android` instead.

If a relative path is used for icons path, it is transformed to an absolute path

`path` configuration is an absolute path to an icons directory. In that regard `assets/icons` and `/assets/icons` are equivalent.

If a relative path is used for icons path, it is transformed to an absolute path

Things are a bit backwards here. A Manifest file is secondary to icons. Historically the library was designed around icons and whatever else (e.g. manifests) were "extra files to generate".

HTML Object Return - Add option to return html un-stringified (for use in libraries/plugins)

Other option would be to expand `FaviconResponse` and add one more field. ```js export interface FaviconResponse { readonly images: FaviconImage[]; readonly files: FaviconFile[]; readonly html: FaviconHtmlElement[]; // string[] readonly htmlTags:...

Option to return un-stringified elements for use in plugins and other libraries

That's great idea. The only concern I have is how to do this and not break existing API.

Add feature to set different source image(s) for each platform.

@hadimostafapour I like the direction where it goes, but I am not sure that such extension of config type is a right thing to do. Let's say, someone wants to...