Andy Thomson

Results 80 comments of Andy Thomson

Thanks for giving this a go. We don't currently have a conversion from Box to an R object. I am working on the `Serialize` and `Deserialize` traits so we can...

You may be able to work around this by manually implementing `From for Robj` which is what we need here. ``` impl From for Robj { fn from(z: &Option) ->...

Note that unwrapping the box will destroy it, so taking a reference to the `Option>` is better.

Here is a more generic one we could use: ``` impl for Robj where &'a T: Into, { fn from(z: &'a Option) -> Self { if let Some(z) = z...

Likewise: ``` use std::convert::{TryFrom, TryInto}; impl TryFrom for Option where Robj: TryInto { type Error = Error; fn try_from(value: Robj) -> Result { Ok(if value.is_null() { None } else {...

The problem with returning a non-static reference is that R does not know how to handle lifetimes. There is no "extra" information that conveys that `left` has the same lifetime...

Looking good so far. Hopefully we can phase out the try_from attribute for the next release.

It would be a blessed relief to drop Win32. I remember Win16 living on like the zombie that refused to die! They have finally decommissioned the 32 bit Viglen machines...

Integer `no_na` calls `INTEGER_NO_NA`. Much would depend on if this is an ALTREP vector. With [#401](https://github.com/extendr/extendr/pull/401) this will mostly use the default R behaviour, but we should also make the...

It would be worth re-testing this with the last two PRs merged. We should raise a separate issue for a good default `no_na()` for `ALTREP` vectors as well as subsetting...