Andy Sweet
Andy Sweet
The warning for `setattr` looks great and should definitely come into v0.4.17. How strongly do you feel about bringing in the thread checks? I still feel like splitting this PR...
@Czaki : as this has two PRs to coordinate (this + docs), feel free to merge both when you'r ready.
> I don't know why this fix even works in the first place... I'll check again tomorrow! If you work it out, please suggest an explanatory comment in the shader!
I will merge this after 24 hours unless anyone objects. Or someone else should feel free to merge it after that time instead.
@Czaki : just double checking - is this good to merge from your perspective?
> @andy-sweet this error is why I had reworked the typing: https://github.com/napari/napari/actions/runs/3205606750/jobs/5238336580#step:8:75 > > I'm not sure how to capture what you want and also avoid that error. `Future` cannot...
This morning it felt like this was almost done, but now it seems there's a way to go. If it helps in the long term, I think it's fine to...
> [This is my thinking on that](https://github.com/napari/napari/pull/5170/files#diff-6aa188e980053de4284e008eab22c9bf8cbc1d9a29fe17687b9879ea70042395R127-R130). I suspect a race condition so its tricky to test. I can try to create a temporary test with a sleep just to...
> I'm perfectly fine with this. I admittedly don't have a great grasp on the visual effects of things that you've noted. I will revert and address the issues with...
> > I think having the ability to control if we wait for all of the slices to be done seems useful to me. But I also appreciate that rendering...