Andy Sweet

Results 82 comments of Andy Sweet

Yep, I suspect the test failures are unrelated. Thanks for the extra tests and comments. I might be able to look at this today, otherwise I won't get to it...

Code changes look great! Your answer to the problem of deciding when to regenerate meshes is always, which I also like because of its simplicity. But as you point out...

Accessing the view bounding box and knowing when it changes on the model side could make the slicing code related to `corner_pixels` and `data_level` much more clear and useful too...

@brisvag , @kevinyamauchi : this PR seems like one of the riskier v0.4.17 candidates because (if I understand correctly), we'll be hitting some of these code paths any time we...

> I propose that if we are able to get this in a mergeable state by the first RC, we go ahead and include it in 0.4.17. Otherwise, we take...

> I thought I was going to have more time early this week, but something came up with my day job and I won't have time to get this over...

Agreed that this seems like a good candidate to bring into v0.4.17. But I'm not familiar enough with the code changes here to approve the PR - can one of...

Reminder that this should ideally be approved by at least one of the existing reviewers: @jni, @alisterburt , @haesleinhuepf , @kevinyamauchi , @tlambert03 If that doesn't happen in 24 hours,...

Based on the discussion here and [on zulip](https://napari.zulipchat.com/#narrow/stream/215289-release/topic/0.2E4.2E17/near/297584783), I think the only thing left to do is add the colormaps. Is that right @psobolewskiPhD ? Can you get that done...

> though it would be nice to get some feedback on the UI aspect, the dimming of the opacity slider, etc. From the screenshots, those look fantastic. But I can...