Andy Sweet

Results 82 comments of Andy Sweet

I came here via [a napari issue](https://github.com/napari/napari/issues/1058), where we run into the same assertion failure (e.g. `assert (c, b) not in self._edges_lookup`) mentioned here and in #1948. @sofroniewn found [a...

> This PR is making me realize you can do the same kind of thing as `add_view` or `add_widget` where you make your own Widget/ViewBox/other widget instance and do `canvas.central_widget...

> Did you want to try setting the default border width for all widgets to 0 and see what tests fail? Sure. I pushed that change to the branch associated...

Yep, looks like some of the tests are failing because of direct image comparison (maybe with some previously prepared golden/standard image?). For example ``` =================================== FAILURES =================================== ___________________________ test_perspective_render ____________________________...

Thanks for creating a separate issue for this @djhoese. I created PR #2248 and described some of my thoughts about those changes. I hope the tests can help clarify what...

@Carreau : this looks like a useful idea, but it's been around for a while without any action. At a minimum, I think you should mark this as a draft...

> * nomenclature (`space` vs `state` vs `viewer`) I'll come back for more discussion, but I vote for anything but `state`. I dislike it because it's vague and general -...

I know it's future work and has already been discussed, but it's hard for me *not* to think about multi-canvas as I re-read this NAP again, especially with some of...

> These things would imply that _each canvas_ would have its own `space` (which could be _the same_ space, but also not). Thanks for the explanation @brisvag! I'm comfortable with...

> * **independent** layerlists By independent, you mean that a layer cannot be in more than one layer list right? > * we first separate slicing state (as per the...