native-client icon indicating copy to clipboard operation
native-client copied to clipboard

Fix "cmd is unknown" errors on version check

Open noppa opened this issue 3 years ago • 2 comments

The execution continued after version check was made, ending up in "cmd is unknown".

noppa avatar Nov 11 '22 11:11 noppa

Can you explain how it helps? How can I reproduce the bug?

andy-portmen avatar Nov 12 '22 05:11 andy-portmen

I don't think this "bug" actually causes any issues that'd be visible to the end user. Without the else if, all version check calls to the native client (i.e. when the "check connection status" is clicked) will respond not only with the version, but also with 'cmd is unknown' error message.

I noticed this when debugging why the extension wasn't working for me. This didn't end up being the solution for my issue - that was just a missing piece in configuration. But I figured that even though this extra error message isn't harming anyone at the moment, it probably wasn't intended behaviour either, hence this PR.

noppa avatar Nov 12 '22 20:11 noppa