Andy Blum
Andy Blum
`ddev debug test` output [here](https://gist.github.com/andy-blum/7e57f331ad7efcd3bb614c0b17ef53f5)
The [demo link](https://video-cta-lockup--carbon-demos.netlify.app/) from the issue is updated to use the CDN deploy previews from this PR. While the browser no longer locks up, the modal containing the media isn't...
There's a change needed to the table-of-contents component. See [here](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/11149/files#diff-6106ea6c90f1bdf5ae8254a3e4795b559041420c9346daeeaa80aebea13c6834)
@marcelojcs make sure to run `yarn ci-check` from the project root. It's pointing out the errors in the ci-check job. ``` carbon-for-ibm-dotcom/packages/carbon-web-components/src/components/checkbox/checkbox-story.ts Warning: 13:10 warning 'ifDefined' is defined but never...
The impact of this change likely won't reflect in bundle sizes, but should appear in total node counts. Card Group with Card-In-Card demos: * [Current v2](https://sandbox.andy-blum.com/ibm/template-minification/v2/card-group-CIC-current.html) * [This PR Preview](https://sandbox.andy-blum.com/ibm/template-minification/v2/card-group-CIC-preview.html)...
Note that the above comment is only testing the _rollup_ changes which affect the CDN assets, not the _gulp_ changes that impact the npm packages.
The `gulp-minify-html-literals` package was from [here](https://gitlab.com/bttg_/gulp-minify-html-literals). I'm not sure why that package no longer exists, but we can remove it from this PR. This PR is also on hold, pending...
FYI #4996 may solve this for you
It would, but that's not a problem for lazy-loaded images or other images that are farther down the page.