bootstrap-vz icon indicating copy to clipboard operation
bootstrap-vz copied to clipboard

Building Docker images with a description fails

Open KellerFuchs opened this issue 8 years ago • 3 comments

The task tasks.image.CreateImage fails when providers.label.description is set, seemingly due to improper quoting in the docker invocation. See build log

KellerFuchs avatar Apr 17 '17 09:04 KellerFuchs

Amusingly, the last commit there was mine (eca54d6c218e7240e70d8e76f441727868e08c95), to fix an issue with the exact same thing. I guess there was a breaking change in the Docker CLI?

KellerFuchs avatar Apr 17 '17 09:04 KellerFuchs

Ah yes, I remember this, there was quite a bit of hassle with those labels.
This:

'LABEL description='"'"'Hashbang shell server, based on Debian jessie'"'"''

looks really bad. What was the value in your manifest? I agree with the sentiment of using a standard escaping function, just be aware of the comment I added in the old escaping function.

Are you up for fixing this?

andsens avatar Apr 23 '17 10:04 andsens

The manifest had this:

description: "Hashbang shell server, based on Debian {system.release}"

We are in the process of moving this particular build away from bootstrap-vz, since we aren't really taking advantage of it there, but I have other manifests that exhibit the same issue so I could prepare a patch for those.

KellerFuchs avatar Apr 23 '17 17:04 KellerFuchs