Andrii Konchyn

Fixed in #917

The fix in TruffleRuby is merged and should be available in the next dev build (I suppose tomorrow?) cc @eregon

I've run Rubocop with profiler (stackprof) on a large Rails application (proprietary) and received a little bit different top 10 list: CLICK ME stackprof tmp/stackprof-cpu.dump --text --sort-total --limit 150 |...

> The listing I gave was with --method 'RuboCop::Cop::Commissioner#trigger_responding_cops', to check from the main dispatch point for slow cops. Thank you. It's very helpful. I profiled rubocop on the whole...

Just for the record. I've profiled rubocop-rspec cops and fixed most not efficient ones: - RSpec/SubjectStub - RSpec/ReturnFromStub - RSpec/InstanceVariable - FactoryBot/AttributeDefinedStatically - RSpec/NestedGroups - RSpec/LetSetup https://github.com/rubocop-hq/rubocop-rspec/pulls?q=is%3Apr+author%3Aandrykonchin+is%3Aclosed+performance+

> @andrykonchin were some of these cops using tokens? No. The common issue is excessive recursion and usage of `def_node_search` macros. > I was looking at SpaceAroundMethodCallOperator and it's quite...

Are these changes still welcome? Looks like all the review comments were addressed. I would like to revive this obsolete PR if it still makes sense.

Thank you!

Could you please clarify what is the conclusion of the discussion and expected behaviour in Crystal? Are the methods mentioned above supposed to behave similarly to the Ruby counterparts?

Thank you for pointing at the previous discussions. Just to be clear - this issue is not about the "expect" syntax or getting rid of monkey patching of Object. It's...