Rosetta icon indicating copy to clipboard operation
Rosetta copied to clipboard

Contributing?

Open michaelaird opened this issue 8 years ago • 3 comments

My team and I have been hacking away at adding more conversions for C# features that we used in our Script# projects. We'd like to contribute it back into the main project.

Please have a look at my branch and let me know what you think. There are several things that are still "work in progress" (like handling the case's inside a switch), but we've handled foreach loops, a rough handling of knockout observables and added a naive handling of csproj files.

There are a number of things that we've identified that we need and will try to implement

  • Generics
  • Convert List to x[]
  • Gracefully handle missing "this"
  • Convert delegates to lambdas
  • Allow for namespace instead of module
  • Call "super" in inherited classes
  • and more!

michaelaird avatar Feb 24 '17 02:02 michaelaird

Hello @michaelaird. Sure thing, nice to have some help. Let me have a better look at your changes.

andry-tino avatar Feb 24 '17 14:02 andry-tino

Great! We're new to using roslyn so feel free to make any "code review" type suggestions on things you think we should do differently.

michaelaird avatar Feb 24 '17 14:02 michaelaird

Yes! In the meantime, please have a look at the Wiki I just updated in the section Contribute guidelines. The section is still to be expanded, but it has already the basic info required for a good contribution.

I am reviewing the code in the meantime. Get back to you with feedback.

andry-tino avatar Feb 25 '17 00:02 andry-tino