Andrus Adamchik
Andrus Adamchik
I guess I don't understand the point of "dryRun"
If I understand correctly, the use case for this is to collect changes, and then handle them using custom code via a listener? I was hoping we can actually encapsulate...
Hi Steve. Here is the example of the change I was proposing. It leaves the public API of OptionMetadata.Builder intact, and simplifies the `CommandMetadata` code. ``` diff --git a/bootique/src/main/java/io/bootique/meta/application/CommandMetadata.java b/bootique/src/main/java/io/bootique/meta/application/CommandMetadata.java...
Merged. Congrats on your first PR! I did some minor polishing per 89602de1487.
Hi Steve, indeed. This is a rather isolated task that would not require and overall design changes. So go for it.
> haven't done much OS, so please forgive me if these are things I should figure out for myself, but I'd love some input before I dive too far in....
> I would think we would not want to negate optionSet.hasArgument(name) because by my reading, the current code is saying "There is no argument, so we do match and therefore...
> It was a little tricky to convert the value and cardinality in a way that didn't feel overwrought, and I may have gone too far that way. I think...
> I'm not sure we break the immutability of OptionMetadata as setValueWithCardinality() was on the OptionMetadata.Builder. Sorry, my bad. You are right. So that's just a question of naming, not...
> Do we want to handle the update to CommandMetadata separately from this issue? Yes, you can open a PR with a description for just the CommandMetadata piece, so that...