standard-contracts icon indicating copy to clipboard operation
standard-contracts copied to clipboard

RLP: adapting to changes in Solidity version 0.5.0

Open christianparpart opened this issue 7 years ago • 2 comments

This PR adapts the RLP.sol to the changes needed when you compile this file with a solidity compiler version 0.5.0+, which is not yet released, but you can test it already with current compiler that has experimental v0.5.0 features enabled.

This PR basically contains the changes we did in order to get our test suite pass.

christianparpart avatar Jul 18 '18 15:07 christianparpart

Shouldn't this also update the assembly?

axic avatar Jul 23 '18 14:07 axic

I vote for updating the assembly and promoting _copyToBytes back to view (both here and in the solidity repo; actually my fault - I should have done that with the constant keyword PR already).

ekpyron avatar Aug 02 '18 14:08 ekpyron