media icon indicating copy to clipboard operation
media copied to clipboard

Add `outlineWidth` to `Cue`

Open LagradOst opened this issue 1 year ago • 5 comments

Fixes #1834, by adding an extra field to Cue to inform the painter about the outline width of the subtitle.

LagradOst avatar Oct 28 '24 13:10 LagradOst

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 28 '24 13:10 google-cla[bot]

This is not ready for review yet, due to the confusing painting in updateWebView that I am unsure how to update. @icbaker could you clarify how to add Cue specific outlines when convertCaptionStyleToCssTextShadow is only called once per list of cues. I dont see a way to make it cue specific in a clean way.

LagradOst avatar Oct 28 '24 13:10 LagradOst

@icbaker I believe I added everything needed for text outline using a span. However I an unable to test the webview text, so I added what I think will work.

LagradOst avatar Nov 01 '24 18:11 LagradOst

@icbaker any update about that PR?

KingLucius avatar Mar 13 '25 14:03 KingLucius

However I an unable to test the webview text, so I added what I think will work.

Why is this? You should be able to enable it in any app using PlayerView (including our demo):

playerView.getSubtitleView().setViewType(SubtitleView.VIEW_TYPE_WEB);

icbaker avatar Apr 29 '25 07:04 icbaker